Bug 87759 – [New Multicolumn] Pull the initial page logical height setup into its own virtual function

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Dave Hyatt]

Pull the initial page logical height setup into its own virtual function. This will allow RenderMultiColumnBlock to do the setup in the derived class (and also makes layoutBlock a little cleaner in the base class even for the old multi-column layout).

[Dave Hyatt]

Created attachment 144587 [details]
Patch

[Dave Hyatt]

Comment on attachment 144587 [details]
Patch

The diff for this looks really funny for anyone reviewing. The code that actually got pulled into the helper function doesn't show up in the diff, since it chose to show the movement of the layoutBlock code instead. I recommend looking at the current source to understand what I did here.

[WebKit Review Bot]

Attachment 144587 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:1399:  One space before end of line comments  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBlock.cpp:1399:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Landed in r118808.