Bug 87745

Summary:

[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient

Product:

WebKit

Reporter:

Simon Pena <spena>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, gustavo, mrobinson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Simon Pena

Reported 2012-05-29 07:20:26 PDT

Building WK2 currently outputs the following warnings: ../../Source/WebKit2/UIProcess/API/gtk/WebKitUIClient.cpp:194:5: warning: missing initializer for member ‘WKPageUIClient::unavailablePluginButtonClicked’ [-Wmissing-field-initializers] ../../Source/WebKit2/UIProcess/API/gtk/WebKitLoaderClient.cpp:151:5: warning: missing initializer for member ‘WKPageLoaderClient::pluginDidFail’ [-Wmissing-field-initializers] The attached patch initializes these members.

Attachments
Patch (2.64 KB, patch) 2012-05-29 07:41 PDT, Simon Pena	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Pena

Comment 1 2012-05-29 07:41:55 PDT

Created attachment 144556 [details] Patch

WebKit Review Bot

Comment 2 2012-05-29 07:44:28 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Carlos Garcia Campos

Comment 3 2012-05-29 07:53:03 PDT

Comment on attachment 144556 [details] Patch Thanks!

WebKit Review Bot

Comment 4 2012-05-29 09:47:19 PDT

Comment on attachment 144556 [details] Patch Clearing flags on attachment: 144556 Committed r118795: <http://trac.webkit.org/changeset/118795>

WebKit Review Bot

Comment 5 2012-05-29 09:47:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.