Bug 87740 – [Qt] REGRESSION(r118568): It broke fast/forms/textarea-maxlength.html on Qt 4.8

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

After http://trac.webkit.org/changeset/118568, fast/forms/textarea-maxlength.html 
started to fail on Qt 4.8 platforms. (It passes on Qt 5, because Qt 5 build uses ICU)

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/forms/textarea-maxlength-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/forms/textarea-maxlength-actual.txt 
@@ -23,8 +23,8 @@
 PASS textArea.value is "A\nB"
 PASS textArea.value is "a\n\n"
 PASS textArea.value is "\n\n\n"
-PASS textArea.value is "AB" + fancyX
-PASS textArea.value.length is 5
+FAIL textArea.value should be ABxĚ̲. Was AB.
+FAIL textArea.value.length should be 5. Was 2.
 PASS textArea.value is "ABC"
 PASS textArea.value is "AB" + u10000
 PASS textArea.value.length is 4

[Csaba Osztrogonác]

I skipped it - http://trac.webkit.org/changeset/118766
Please unskip it with the proper fix.

Created attachment 144588 [details]
Possible fix

Sorry about breaking this! I don’t have access to this build configuration, but I think this patch will fix the regression. Can you try it? Thanks!

[Csaba Osztrogonác]

(In reply to comment #2)
> Created an attachment (id=144588) [details]
> Possible fix
> 
> Sorry about breaking this! I don’t have access to this build configuration, but I think this patch will fix the regression. Can you try it? Thanks!

Not problem. I tried your patch and it fixed fast/forms/textarea-maxlength.html test. Thanks.

Created attachment 144901 [details]
Use the return value of setUpIterator in the NonSharedCharacterBreakIterator constructor

Fixed in <http://trac.webkit.org/r118990>.