Bug 87729

Summary: [GTK] fast tests needs rebaseline after r118733
Product: WebKit Reporter: Simon Pena <spena>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Simon Pena
Reported 2012-05-29 04:33:06 PDT
Gardening: fast tests need rebaseline after http://trac.webkit.org/changeset/118733
Attachments
Patch (24.58 KB, patch)
2012-05-29 04:37 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Patch (173.61 KB, patch)
2012-05-29 04:52 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Patch (149.60 KB, patch)
2012-05-29 07:13 PDT, Simon Pena 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Pena
Comment 1 2012-05-29 04:37:27 PDT
Created attachment 144518 [details] Patch
Mario Sanchez Prada
Comment 2 2012-05-29 04:45:07 PDT
Comment on attachment 144518 [details] Patch We need to add new pixel tests expectations too for most of those tests
Simon Pena
Comment 3 2012-05-29 04:52:48 PDT
Created attachment 144522 [details] Patch
Mario Sanchez Prada
Comment 4 2012-05-29 05:07:00 PDT
Comment on attachment 144522 [details] Patch Looks good
Mario Sanchez Prada
Comment 5 2012-05-29 05:51:31 PDT
Comment on attachment 144522 [details] Patch Removing the cq+ flag since Zan already pushed a new changeset with the needed rebaseline. Still, the new pngs are missing, but Simon has agreed to upload a new patch here with those, to complete the process
Simon Pena
Comment 6 2012-05-29 07:13:21 PDT
Created attachment 144551 [details] Patch
Simon Pena
Comment 7 2012-05-29 07:14:08 PDT
(In reply to comment #5) > (From update of attachment 144522 [details]) > Removing the cq+ flag since Zan already pushed a new changeset with the needed rebaseline. > > Still, the new pngs are missing, but Simon has agreed to upload a new patch here with those, to complete the process And there go the updated pngs.
Mario Sanchez Prada
Comment 8 2012-05-29 07:25:32 PDT
Comment on attachment 144551 [details] Patch Let's get them in
WebKit Review Bot
Comment 9 2012-05-29 09:32:16 PDT
Comment on attachment 144551 [details] Patch Clearing flags on attachment: 144551 Committed r118792: <http://trac.webkit.org/changeset/118792>
WebKit Review Bot
Comment 10 2012-05-29 09:32:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.