Bug 87729 - [GTK] fast tests needs rebaseline after r118733
Summary: [GTK] fast tests needs rebaseline after r118733
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-29 04:33 PDT by Simon Pena
Modified: 2012-05-29 09:32 PDT (History)
1 user (show)

See Also:

Attachments
Patch (24.58 KB, patch)
2012-05-29 04:37 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Patch (173.61 KB, patch)
2012-05-29 04:52 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Patch (149.60 KB, patch)
2012-05-29 07:13 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2012-05-29 04:33:06 PDT 
Gardening: fast tests need rebaseline after http://trac.webkit.org/changeset/118733
Comment 1 Simon Pena 2012-05-29 04:37:27 PDT 
Created attachment 144518 [details]
Patch
Comment 2 Mario Sanchez Prada 2012-05-29 04:45:07 PDT 
Comment on attachment 144518 [details]
Patch

We need to add new pixel tests expectations too for most of those tests
Comment 3 Simon Pena 2012-05-29 04:52:48 PDT 
Created attachment 144522 [details]
Patch
Comment 4 Mario Sanchez Prada 2012-05-29 05:07:00 PDT 
Comment on attachment 144522 [details]
Patch

Looks good
Comment 5 Mario Sanchez Prada 2012-05-29 05:51:31 PDT 
Comment on attachment 144522 [details]
Patch

Removing the cq+ flag since Zan already pushed a new changeset with the needed rebaseline.

Still, the new pngs are missing, but Simon has agreed to upload a new patch here with those, to complete the process
Comment 6 Simon Pena 2012-05-29 07:13:21 PDT 
Created attachment 144551 [details]
Patch
Comment 7 Simon Pena 2012-05-29 07:14:08 PDT 
(In reply to comment #5)
> (From update of attachment 144522 [details])
> Removing the cq+ flag since Zan already pushed a new changeset with the needed rebaseline.
> 
> Still, the new pngs are missing, but Simon has agreed to upload a new patch here with those, to complete the process

And there go the updated pngs.
Comment 8 Mario Sanchez Prada 2012-05-29 07:25:32 PDT 
Comment on attachment 144551 [details]
Patch

Let's get them in
Comment 9 WebKit Review Bot 2012-05-29 09:32:16 PDT 
Comment on attachment 144551 [details]
Patch

Clearing flags on attachment: 144551

Committed r118792: <http://trac.webkit.org/changeset/118792>
Comment 10 WebKit Review Bot 2012-05-29 09:32:20 PDT 
All reviewed patches have been landed.  Closing bug.