Bug 87727

Summary: [EFL] Enable CSS_IMAGE_SET flag
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
gyuyoung.kim: commit-queue-
Patch
none
Patch
none
Patch none

Description Chris Dumez 2012-05-29 04:11:23 PDT 
We need to enable the CSS_IMAGE_SET flag on EFL port. It is tested by:
  fast/css/image-set-parsing.html

It is already enabled at least on Mac and Chromium ports.

See this email for more information about this feature:
https://lists.webkit.org/pipermail/webkit-dev/2012-March/019722.html
Comment 1 Chris Dumez 2012-05-29 04:17:39 PDT 
Created attachment 144510 [details]
Patch
Comment 2 Gyuyoung Kim 2012-05-29 06:54:57 PDT 
Comment on attachment 144510 [details]
Patch

Attachment 144510 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12849482
Comment 3 Chris Dumez 2012-05-29 10:02:12 PDT 
Created attachment 144574 [details]
Patch
Comment 4 Chris Dumez 2012-05-29 10:18:21 PDT 
Created attachment 144579 [details]
Patch
Comment 5 Raphael Kubo da Costa (:rakuco) 2012-05-29 10:34:16 PDT 
Comment on attachment 144579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144579&action=review

The feature itself seems to have been landed the wrong way, with a define in Platform.h instead of being added to FeatureList.pm, which is sad.

> Source/WebCore/CMakeLists.txt:1518
> +IF (ENABLE_CSS_IMAGE_SET)
> +    LIST(APPEND WebCore_SOURCES
> +        css/CSSImageSetValue.cpp
> +        rendering/style/StyleCachedImageSet.cpp
> +    )
> +ENDIF ()

These files are already protected by ENABLE(CSS_IMAGE_SET) ifdefs, so they can be added unconditionally to the build.
Comment 6 Chris Dumez 2012-05-29 11:15:26 PDT 
Created attachment 144590 [details]
Patch

Take rakuco's feedback into consideration.
Comment 7 Raphael Kubo da Costa (:rakuco) 2012-05-29 11:28:23 PDT 
Comment on attachment 144590 [details]
Patch

LGTM.
Comment 8 Gyuyoung Kim 2012-05-29 17:49:27 PDT 
Comment on attachment 144590 [details]
Patch

Looks good to me.
Comment 9 WebKit Review Bot 2012-05-31 07:47:45 PDT 
Comment on attachment 144590 [details]
Patch

Clearing flags on attachment: 144590

Committed r119102: <http://trac.webkit.org/changeset/119102>
Comment 10 WebKit Review Bot 2012-05-31 07:47:50 PDT 
All reviewed patches have been landed.  Closing bug.