Bug 87726

Summary: Split svg/dom/viewspec-parser.html in smaller tests
Product: WebKit Reporter: Marcus Bulach <bulach>
Component: Tools / TestsAssignee: Marcus Bulach <bulach>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87772    
Attachments:
Description Flags
Patch
none
Patch kling: review+

Marcus Bulach
Reported 2012-05-29 04:06:51 PDT
svg/dom/viewspec-parser.html introduced by r118735 is a very large test that times out on chromium. Split in 5 smaller tests.
Attachments
Patch (208.54 KB, patch)
2012-05-29 04:13 PDT, Marcus Bulach 		no flags
DetailsFormatted DiffDiff
Patch (248.99 KB, patch)
2012-05-29 06:21 PDT, Marcus Bulach 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marcus Bulach
Comment 1 2012-05-29 04:13:20 PDT
Created attachment 144509 [details] Patch
Andreas Kling
Comment 2 2012-05-29 06:09:20 PDT
Comment on attachment 144509 [details] Patch LGTM, but don't forget to remove viewspec-parser-expected.txt as well.
Marcus Bulach
Comment 3 2012-05-29 06:21:26 PDT
Created attachment 144539 [details] Patch
Marcus Bulach
Comment 4 2012-05-29 07:53:35 PDT
Committed r118776: <http://trac.webkit.org/changeset/118776>
Alexey Proskuryakov
Comment 5 2012-06-01 11:49:41 PDT
These new tests are very flaky on bots. Could you please take a look? http://build.webkit.org/results/Lion%20Release%20(WebKit2%20Tests)/r119252%20(7773)/results.html -This test fuzzes the transform parser with semi-random attribute values and dumps the results of any values that parse successfully. +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". ...
Note You need to log in before you can comment on or make changes to this bug.