Bug 87715

Summary: [CSS] Remove a dummy style sheet from CSSParser::parseFlowThread()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: CSSAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, koivisto, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87625    
Attachments:
Description Flags
Patch
haraken: commit-queue-
patch for landing none

Kentaro Hara
Reported 2012-05-29 02:35:19 PDT
r118736 changed CSSGrammer.y so that it works fine with no style sheet. r118736 removed a dummy style sheet from CSSParser::parserSelector(). Now we can safely remove a dummy style sheet from parserFlowThread().
Attachments
Patch (1.60 KB, patch)
2012-05-29 02:36 PDT, Kentaro Hara 		haraken: commit-queue-
DetailsFormatted DiffDiff
patch for landing (1.59 KB, patch)
2012-05-29 17:10 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-29 02:36:44 PDT
Created attachment 144494 [details] Patch
Darin Adler
Comment 2 2012-05-29 13:02:28 PDT
Comment on attachment 144494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144494&action=review > Source/WebCore/ChangeLog:3 > + [CSS] Remove a dummy style sheet from CSSParser::parseFlowThread() I don’t think we need a [CSS] prefix on a CSS bug title. > Source/WebCore/ChangeLog:8 > + r118736 changed CSSGrammer.y so that it works fine with no style sheet. CSSGrammar is misspelled here.
Kentaro Hara
Comment 3 2012-05-29 15:08:01 PDT
Comment on attachment 144494 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144494&action=review >> Source/WebCore/ChangeLog:8 >> + r118736 changed CSSGrammer.y so that it works fine with no style sheet. > > CSSGrammar is misspelled here. Oops. Let me fix it.
Kentaro Hara
Comment 4 2012-05-29 17:10:53 PDT
Created attachment 144647 [details] patch for landing
WebKit Review Bot
Comment 5 2012-05-29 21:37:40 PDT
Comment on attachment 144647 [details] patch for landing Clearing flags on attachment: 144647 Committed r118892: <http://trac.webkit.org/changeset/118892>
Note You need to log in before you can comment on or make changes to this bug.