|Summary:||Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag|
|Product:||WebKit||Reporter:||David Barr <davidbarr>|
|Component:||CSS||Assignee:||David Barr <davidbarr>|
|Severity:||Normal||CC:||abarth, darin, dglazkov, eoconnor, mikelawther, rakuco, simon.fraser, thorton, vestbo, webkit.review.bot|
|Version:||528+ (Nightly build)|
|Bug Depends on:|
|Bug Blocks:||85262, 85332|
Description David Barr 2012-05-28 17:48:50 PDT
The css3-images module is at candidate recommendation. One property from that module that is not yet implemented in WebKit is image-resolution. http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution I propose to introduce the property, initially behind a compile time flag.
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-05-28 20:17:22 PDT
Comment on attachment 144432 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144432&action=review > Source/cmake/WebKitFeatures.cmake:23 > + WEBKIT_OPTION_DEFINE(ENABLE_CSS_IMAGE_RESOLUTION "Toggle CSS image-resolution support" OFF) Thanks for taking care of the CMake side. You also need to add a definition to Source/cmakeconfig.cmake.h.
Comment 3 David Barr 2012-05-28 20:52:22 PDT
I think Source/cmakeconfig.h.cmake is only for enabled features.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-05-28 21:02:55 PDT
(In reply to comment #3) > I think Source/cmakeconfig.h.cmake is only for enabled features. Not really, disabled ones just get defined to 0 there. You could add it when the feature gets enabled, but it doesn't scale well since more than one port uses CMake.
Comment 5 David Barr 2012-05-28 21:40:11 PDT
I stand corrected. The basis for my false presumption was that the following disabled features are absent from Source/cmakeconfig.h.cmake ENABLE_ANIMATION_API ENABLE_CSS_FILTERS ENABLE_CSS_IMAGE_RESOLUTION ENABLE_CSS_SHADERS ENABLE_CSS_VARIABLES ENABLE_DIRECTORY_UPLOAD ENABLE_GAMEPAD ENABLE_HIGH_DPI_CANVAS ENABLE_INPUT_SPEECH ENABLE_LEGACY_WEBKIT_BLOB_BUILDER ENABLE_LINK_PREFETCH ENABLE_MEDIA_SOURCE ENABLE_MEDIA_STATISTICS ENABLE_MEDIA_STREAM ENABLE_MHTML ENABLE_PLUGIN_PROXY_FOR_VIDEO ENABLE_QUOTA ENABLE_REPAINT_THROTTLING ENABLE_SCRIPTED_SPEECH ENABLE_SHADOW_DOM ENABLE_STYLE_SCOPED
Comment 6 Raphael Kubo da Costa (:rakuco) 2012-05-28 21:45:24 PDT
Indeed. People are usually unaware that that file needs to be changed (I've added it to http://trac.webkit.org/wiki/AddingFeatures). Hopefully the situation will be improved once Eric's work to generate the feature definitions for all build systems automatically lands (since we could also generate that file).
Comment 7 David Barr 2012-05-28 21:46:42 PDT
Created attachment 144442 [details] Patch Updated Source/cmakeconfig.h.cmake and ChangeLog.
Comment 8 Eric Seidel (no email) 2012-05-29 03:04:45 PDT
Comment on attachment 144442 [details] Patch This looks mostly correct. I suspect you missed Gtk.
Comment 9 WebKit Review Bot 2012-05-29 07:44:55 PDT
Comment on attachment 144442 [details] Patch Clearing flags on attachment: 144442 Committed r118774: <http://trac.webkit.org/changeset/118774>
Comment 10 WebKit Review Bot 2012-05-29 07:45:02 PDT
All reviewed patches have been landed. Closing bug.