Bug 87684

Summary: Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, darin, dglazkov, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Luke Macpherson
Reported 2012-05-28 17:08:14 PDT
Implement post-landing feedback for WebKitCSSTransformValue::customCSSText().
Attachments
Patch (2.03 KB, patch)
2012-05-28 17:11 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (2.07 KB, patch)
2012-05-29 16:48 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-05-28 17:11:06 PDT
Created attachment 144411 [details] Patch
Caio Marcelo de Oliveira Filho
Comment 2 2012-05-29 00:44:28 PDT
Comment on attachment 144411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +const char* const transformName[22] = { I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum.
Darin Adler
Comment 3 2012-05-29 09:46:19 PDT
Comment on attachment 144411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review >> Source/WebCore/css/WebKitCSSTransformValue.cpp:36 >> +const char* const transformName[22] = { > > I think the idea was to get rid of this "22" as well, and use "const char* const transformName[] = { ...". > > I also think it is a good idea to point out that this needs to be synchronized with TransformOperationType enum. Agreed on both points.
Luke Macpherson
Comment 4 2012-05-29 16:48:43 PDT
Created attachment 144640 [details] Patch
Darin Adler
Comment 5 2012-05-29 17:28:35 PDT
Comment on attachment 144640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144640&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +// These names must be kept in sync with TransformOperationType. Normally to keep something in sync we need comments on both things, otherwise someone changes one without updating the other.
WebKit Review Bot
Comment 6 2012-05-29 20:30:41 PDT
Comment on attachment 144640 [details] Patch Clearing flags on attachment: 144640 Committed r118885: <http://trac.webkit.org/changeset/118885>
WebKit Review Bot
Comment 7 2012-05-29 20:30:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.