Bug 87676

Summary: [BlackBerry] Add malloc info to about:memory page
Product: WebKit Reporter: Yong Li <yong.li.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: efidler, kpiascik, mifenton, tonikitoo, webkit.review.bot
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
the patch
none
second try
none
again
none
make process total memory usage more readable.
none
add change log none

Yong Li
Reported 2012-05-28 13:29:27 PDT
to add malloc info to about:memory page
Attachments
the patch (1.90 KB, patch)
2012-05-29 10:30 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
second try (1.90 KB, patch)
2012-05-29 10:33 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
again (5.12 KB, patch)
2012-05-29 14:16 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
make process total memory usage more readable. (2.87 KB, patch)
2012-07-16 10:51 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
add change log (3.54 KB, patch)
2012-07-16 11:28 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-05-29 10:30:26 PDT
Created attachment 144583 [details] the patch
Yong Li
Comment 2 2012-05-29 10:33:03 PDT
Created attachment 144584 [details] second try
Konrad Piascik
Comment 3 2012-05-29 10:33:48 PDT
Comment on attachment 144583 [details] the patch This is not related to the patch itself, but AboutData.cpp would benefit from a StringBuilder refactor.
WebKit Review Bot
Comment 4 2012-05-29 10:35:48 PDT
Attachment 144584 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:222: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Konrad Piascik
Comment 5 2012-05-29 10:36:15 PDT
Comment on attachment 144584 [details] second try View in context: https://bugs.webkit.org/attachment.cgi?id=144584&action=review > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:245 > + page += "</body></html>"; shouldn't the </table> tag from line 242 be outside the #if define block?
Yong Li
Comment 6 2012-05-29 10:40:59 PDT
Comment on attachment 144584 [details] second try I realized I can simplify the code with an existing function... also, will add more info as suggested by Eli
Yong Li
Comment 7 2012-05-29 10:41:35 PDT
(In reply to comment #5) > (From update of attachment 144584 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144584&action=review > > > Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp:245 > > + page += "</body></html>"; > > shouldn't the </table> tag from line 242 be outside the #if define block? yes. fixed by second patch
Yong Li
Comment 8 2012-05-29 13:48:27 PDT
postponed
Yong Li
Comment 9 2012-05-29 14:16:13 PDT
Created attachment 144618 [details] again
Rob Buis
Comment 10 2012-05-29 14:19:42 PDT
Comment on attachment 144618 [details] again Looks good.
Yong Li
Comment 11 2012-05-29 14:40:58 PDT
reopen
WebKit Review Bot
Comment 12 2012-05-29 15:59:32 PDT
Comment on attachment 144618 [details] again Clearing flags on attachment: 144618 Committed r118847: <http://trac.webkit.org/changeset/118847>
WebKit Review Bot
Comment 13 2012-05-29 15:59:38 PDT
All reviewed patches have been landed. Closing bug.
Yong Li
Comment 14 2012-07-13 12:06:27 PDT
reopen to make a change
Yong Li
Comment 15 2012-07-16 10:51:31 PDT
Created attachment 152564 [details] make process total memory usage more readable.
Yong Li
Comment 16 2012-07-16 11:28:08 PDT
Created attachment 152571 [details] add change log
Rob Buis
Comment 17 2012-07-16 11:36:24 PDT
Comment on attachment 152571 [details] add change log LGTM.
WebKit Review Bot
Comment 18 2012-07-16 11:59:40 PDT
Comment on attachment 152571 [details] add change log Clearing flags on attachment: 152571 Committed r122745: <http://trac.webkit.org/changeset/122745>
WebKit Review Bot
Comment 19 2012-07-16 11:59:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.