Summary: | [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-05-28 06:10:33 PDT
Created attachment 144345 [details]
patch
Comment on attachment 144345 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144345&action=review > Tools/DumpRenderTree/efl/EventSender.cpp:124 > + KeyEventInfo(const CString& keyName, unsigned modifiers) > + : keyName(keyName) > + , modifiers(modifiers) Instead of adding a new constructor, I'd change the order of parameters in the other one and make keyString an optional last parameter whose default value is an empty string. Created attachment 144353 [details]
patch v2 (Review remarks are met)
(In reply to comment #2) > (From update of attachment 144345 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144345&action=review > > > Tools/DumpRenderTree/efl/EventSender.cpp:124 > > + KeyEventInfo(const CString& keyName, unsigned modifiers) > > + : keyName(keyName) > > + , modifiers(modifiers) > > Instead of adding a new constructor, I'd change the order of parameters in the other one and make keyString an optional last parameter whose default value is an empty string. done. Comment on attachment 144353 [details]
patch v2 (Review remarks are met)
Looks good, thanks.
Comment on attachment 144353 [details]
patch v2 (Review remarks are met)
Looks good to me too.
Comment on attachment 144353 [details]
patch v2 (Review remarks are met)
rs=me
Comment on attachment 144353 [details] patch v2 (Review remarks are met) Clearing flags on attachment: 144353 Committed r118760: <http://trac.webkit.org/changeset/118760> All reviewed patches have been landed. Closing bug. |