Bug 8765

Summary: Random crashes on TOT since the form state change
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: FormsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Major CC: mitz
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch based on Mitz's analysis
none
patch with improved change log mjs: review+

Maciej Stachowiak
Reported 2006-05-07 01:26:06 PDT
The recent form state change apparently caused a bunch of random memory trashers. Here's one set of steps that consistently reproduces a crash for me: 1) Go to http://www.cnn.com and wait for it to fully load. 2) Click any link. 3) Go back. Darin has a patch for this attached to a bug where this was misdiagnosed as the cause.
Attachments
patch based on Mitz's analysis (3.29 KB, patch)
2006-05-07 10:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
patch with improved change log (3.63 KB, patch)
2006-05-07 10:56 PDT, Darin Adler 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-05-07 04:46:53 PDT
Darin's patch is attached to bug 8753.
Darin Adler
Comment 2 2006-05-07 10:48:54 PDT
Created attachment 8144 [details] patch based on Mitz's analysis
Darin Adler
Comment 3 2006-05-07 10:56:18 PDT
Created attachment 8145 [details] patch with improved change log
Maciej Stachowiak
Comment 4 2006-05-07 21:45:42 PDT
Comment on attachment 8145 [details] patch with improved change log r=me
Maciej Stachowiak
Comment 5 2006-05-07 21:52:21 PDT
People have been complaining about the crasher so I went ahead and commited this, hope you don't mind, Darin.
Darin Adler
Comment 6 2006-05-07 22:54:03 PDT
(In reply to comment #5) > People have been complaining about the crasher so I went ahead and commited > this, hope you don't mind, Darin. Not at all. I've been waiting on review or I would have committed a while back.
Note You need to log in before you can comment on or make changes to this bug.