Summary: | [Shadow DOM] Add an assertion to make sure that an inaccessible node is not set to event's target or relatedTarget in event dispatching | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | DOM | Assignee: | Hayato Ito <hayato> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dglazkov, dominicc, morrita, shinyak, tasak, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 59805 | ||||||||
Attachments: |
|
Description
Hayato Ito
2012-05-28 02:12:52 PDT
Created attachment 144335 [details]
add assertions
Comment on attachment 144335 [details] add assertions View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > Source/WebCore/dom/EventContext.h:52 > + bool accessible(Node*); Might as well not compile it in NDEBUG. Thank you for the review. (In reply to comment #2) > (From update of attachment 144335 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144335&action=review > > > Source/WebCore/dom/EventContext.h:52 > > + bool accessible(Node*); > > Might as well not compile it in NDEBUG. Okay. I'll guard it using NDEBUG. Let me land this patch after that. Created attachment 144676 [details]
Patch for landing
Comment on attachment 144676 [details] Patch for landing Clearing flags on attachment: 144676 Committed r118889: <http://trac.webkit.org/changeset/118889> All reviewed patches have been landed. Closing bug. |