| Summary: | [EFL] Compilation warning in DumpRenderTreeView.cpp | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 144304 [details]
Patch
Comment on attachment 144304 [details]
Patch
Looks fine. By the way, don't you need to fix return type as well ?
static *int64_t* onExceededApplicationCacheQuota ?
(In reply to comment #2) > (From update of attachment 144304 [details]) > Looks fine. By the way, don't you need to fix return type as well ? > > static *int64_t* onExceededApplicationCacheQuota ? It makes sense. Created attachment 144310 [details]
Patch
Comment on attachment 144310 [details]
Patch
Looks good to me now.
Comment on attachment 144310 [details]
Patch
Looks good, thanks.
Comment on attachment 144310 [details] Patch Clearing flags on attachment: 144310 Committed r118729: <http://trac.webkit.org/changeset/118729> All reviewed patches have been landed. Closing bug. |
We get the following compilation warning on the build bot: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:135:36: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 5 has type ‘int64_t {aka long int}’ [-Wformat]