Bug 87628

Summary:

Web Inspector: dom counters graphs vanish on switching between timeline views

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	vsevik: review+
Patch for landing	none

Yury Semikhatsky

Reported 2012-05-28 00:32:30 PDT

1. Go to Timeline and start recording events. 2. Switch to the memory view. See DOM counters graphs there. 3. Stop recording and switch to the events view and back. Result: counters section is cleared.

Attachments
Patch (3.07 KB, patch) 2012-05-28 01:03 PDT, Yury Semikhatsky	vsevik: review+	Details Formatted Diff Diff
Patch for landing (4.27 KB, patch) 2012-05-28 03:17 PDT, Yury Semikhatsky	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2012-05-28 00:33:28 PDT

Also there is an exception in the console on click in the counters area. [12433:12433:236022046902:ERROR:CONSOLE(309)] "Uncaught TypeError: Cannot read property 'time' of undefined", source: chrome-devtools://devtools/MemoryStatistics.js (309)

Yury Semikhatsky

Comment 2 2012-05-28 01:03:51 PDT

Created attachment 144295 [details] Patch

Vsevolod Vlasov

Comment 3 2012-05-28 01:43:50 PDT

Comment on attachment 144295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > - addTimlineEvent: function(event) Could you please fix spelling (addTimelineEvent) while you are at it?

Andrey Kosyakov

Comment 4 2012-05-28 02:57:39 PDT

Comment on attachment 144295 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > + addTimlineEvent: function(record) addTimelineRecord?

Yury Semikhatsky

Comment 5 2012-05-28 03:17:57 PDT

Created attachment 144319 [details] Patch for landing

Yury Semikhatsky

Comment 6 2012-05-28 03:18:47 PDT

(In reply to comment #3) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > > Source/WebCore/inspector/front-end/MemoryStatistics.js:-254 > > - addTimlineEvent: function(event) > > Could you please fix spelling (addTimelineEvent) while you are at it? Done. Renamed the method. (In reply to comment #4) > (From update of attachment 144295 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144295&action=review > > This looks ok, but you may also want to consider directly subscribing to WebInspector.TimelineModel.Events.RecordAdded/RecordsCleared from the model. > Good point. Done. > > Source/WebCore/inspector/front-end/MemoryStatistics.js:254 > > + addTimlineEvent: function(record) > > addTimelineRecord? Done.

Yury Semikhatsky

Comment 7 2012-05-28 03:20:56 PDT

Committed r118670: <http://trac.webkit.org/changeset/118670>

Note You need to log in before you can comment on or make changes to this bug.