Bug 87608 – HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()

• Component: Forms
• Status: RESOLVED FIXED

[Hajime Morrita]

This is a preparation for Bug 87223. 

ValidationMessage mutates DOM tree. But mutating DOM tree during detach() causes troubles
which we hit by the change on Bug 87223.

It could be moved to removedFrom().

[Hajime Morrita]

Created attachment 144256 [details]
Patch

[Kent Tamura]

Comment on attachment 144256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=144256&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:76
>  void HTMLFormControlElement::detach()
>  {
> -    m_validationMessage = nullptr;
>      HTMLElement::detach();
>  }

So, we can remove HTMLFormControlElement::detach().

[Hajime Morrita]

Comment on attachment 144256 [details]
Patch

> So, we can remove HTMLFormControlElement::detach().
True. will do. Thanks for taking look!

[Hajime Morrita]

Created attachment 144264 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 144264 [details]
Patch for landing

Clearing flags on attachment: 144264

Committed r118664: <http://trac.webkit.org/changeset/118664>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.