Bug 87601

Summary:

[BlackBerry] Add support for layers with scale invariant size

Product:

WebKit

Reporter:

Arvid Nilsson <anilsson>

Component:

WebKit BlackBerry

Assignee:

Arvid Nilsson <anilsson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kpiascik, manyoso, mifenton, mlattanzio, rwlbuis, staikos, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

87600

Bug Blocks:

87602

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Arvid Nilsson

Reported 2012-05-27 15:03:33 PDT

To support layers that have a "floating" appearance, i.e. don't change size when the web page is drawn at a different scale, we add a new layer property named "sizeIsScaleInvariant". The anchor position will still be given in document coordinates for these "floating" layers, so this is well suited for interface elements like selection handles whose size is always the same but move with the web page contents. PR #156812 Please note that this has not been internally reviewed yet, so it needs actual review. And also, it has a dependency that needs to be landed first.

Attachments
Patch (18.40 KB, patch) 2012-05-27 15:38 PDT, Arvid Nilsson	no flags	Details Formatted Diff Diff
Patch (18.40 KB, patch) 2012-05-27 16:09 PDT, Arvid Nilsson	no flags	Details Formatted Diff Diff
Patch (18.40 KB, patch) 2012-05-28 13:48 PDT, Arvid Nilsson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Arvid Nilsson

Comment 1 2012-05-27 15:38:57 PDT

Created attachment 144243 [details] Patch

Arvid Nilsson

Comment 2 2012-05-27 15:50:22 PDT

Comment on attachment 144243 [details] Patch Hang on, something's not quite right here

Arvid Nilsson

Comment 3 2012-05-27 16:09:50 PDT

Created attachment 144248 [details] Patch

Yong Li

Comment 4 2012-05-28 09:08:24 PDT

Comment on attachment 144248 [details] Patch Minor: It is a little bit weird to me "scale" is the first argument even it can be ignored. Does it make sense to store 1/scale if it is used very often? internally LGTM

Rob Buis

Comment 5 2012-05-28 09:36:59 PDT

Comment on attachment 144248 [details] Patch Ok.

Arvid Nilsson

Comment 6 2012-05-28 09:39:46 PDT

(In reply to comment #4) > (From update of attachment 144248 [details]) > Minor: It is a little bit weird to me "scale" is the first argument even it can be ignored. Does it make sense to store 1/scale if it is used very often? > > internally LGTM Layers which use 1/scale are very uncommon, it's only the selection handles andd fcc. I initially had it last, then moved it first on a whim... It doesn't matter all that much does it? I was thinking about the order you'd use the params (if you used them all)

Arvid Nilsson

Comment 7 2012-05-28 13:48:25 PDT

Created attachment 144395 [details] Patch

Arvid Nilsson

Comment 8 2012-05-28 13:49:27 PDT

Comment on attachment 144395 [details] Patch The dependency, #87600 changed after review comments, so this one needed to be updated to apply cleanly.

Rob Buis

Comment 9 2012-05-28 14:18:38 PDT

Comment on attachment 144395 [details] Patch Looks fine.

WebKit Review Bot

Comment 10 2012-05-28 15:49:34 PDT

Comment on attachment 144395 [details] Patch Clearing flags on attachment: 144395 Committed r118710: <http://trac.webkit.org/changeset/118710>

WebKit Review Bot

Comment 11 2012-05-28 15:49:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.