Bug 87586

Summary: [watchlist] Add myself & a rule for MathML
Product: WebKit Reporter: Dave Barton <dbarton>
Component: Tools / TestsAssignee: Dave Barton <dbarton>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Dave Barton
Reported 2012-05-26 21:18:33 PDT
[watchlist] Add myself & a rule for MathML
Attachments
Patch (1.66 KB, patch)
2012-05-26 21:19 PDT, Dave Barton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Barton
Comment 1 2012-05-26 21:19:44 PDT
Created attachment 144214 [details] Patch
Adam Barth
Comment 2 2012-05-27 00:16:45 PDT
Comment on attachment 144214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144214&action=review > Tools/Scripts/webkitpy/common/config/watchlist:159 > + "filename": r".*mathml", Do you need the .* in the beginning? I guess it doesn't hurt.
WebKit Review Bot
Comment 3 2012-05-27 00:40:58 PDT
Comment on attachment 144214 [details] Patch Clearing flags on attachment: 144214 Committed r118623: <http://trac.webkit.org/changeset/118623>
WebKit Review Bot
Comment 4 2012-05-27 00:41:02 PDT
All reviewed patches have been landed. Closing bug.
Dave Barton
Comment 5 2012-05-27 09:48:29 PDT
Comment on attachment 144214 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144214&action=review >> Tools/Scripts/webkitpy/common/config/watchlist:159 >> + "filename": r".*mathml", > > Do you need the .* in the beginning? I guess it doesn't hurt. Yes, "filename" is a prefix match. I've created bug 87592 with a patch to clarify this. Thanks for the comment & review.
Note You need to log in before you can comment on or make changes to this bug.