Bug 87582

Summary: When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Page LoadingAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, darin, japhet, kling, psolanki, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Benjamin Poulain
Reported 2012-05-26 15:04:31 PDT
When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called. <rdar://problem/11476505>
Attachments
Patch (14.23 KB, patch)
2012-05-26 15:42 PDT, Benjamin Poulain 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-05-26 15:42:30 PDT
Created attachment 144208 [details] Patch
Darin Adler
Comment 2 2012-05-26 16:55:41 PDT
Comment on attachment 144208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144208&action=review > Source/WebCore/loader/MainResourceLoader.cpp:701 > + ResourceRequest r(m_initialRequest); > + m_initialRequest = ResourceRequest(); > + loadNow(r); As long as you’re touching this code, it might be nice to use a word or words for the name rather than just a letter. I’d suggest initialRequest or request or localCopyOfRequest.
Benjamin Poulain
Comment 3 2012-05-27 14:32:06 PDT
Committed r118631: <http://trac.webkit.org/changeset/118631>
Darin Adler
Comment 4 2012-05-29 10:24:41 PDT
After a comment from Alexey I realize this strikes at the question of what “sending” a request is.
Note You need to log in before you can comment on or make changes to this bug.