Bug 87564 – [BlackBerry] Plumb through the return value of makeCurrent to the caller

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Arvid Nilsson]

Source/WebKit/blackberry:
    
    2012-04-21  Arvid Nilsson  <[e-mail]>
    
            Plumb through the return value of makeCurrent to the caller
            PR #149721
    
            Reviewed by George Staikos.
    
            * WebKitSupport/GLES2Context.cpp:
            (BlackBerry::WebKit::GLES2Context::makeCurrent):
    
    Source/WebCore:
    
    2012-04-21  Arvid Nilsson  <[e-mail]>
    
            Bail if we fail to make the context current
            PR #149721
    
            Let initializeSharedGLObjects return false if we fail to make the GL
            context current, so we never enter the "hardware compositing" state.
    
            Also bail from drawLayers() if we're not hardware compositing.
    
            Reviewed by George Staikos.
    
            Tested by forcing the GLES2Context to return false from makeCurrent.
    
            * platform/graphics/blackberry/LayerRenderer.cpp:
            (WebCore::LayerRenderer::~LayerRenderer):
            (WebCore::LayerRenderer::drawLayers):
            (WebCore::LayerRenderer::initializeSharedGLObjects):

[Arvid Nilsson]

Created attachment 144227 [details]
Patch

[Mike Fenton]

Looks good to me.

[Rob Buis]

Comment on attachment 144227 [details]
Patch

Looks good.

[WebKit Review Bot]

Comment on attachment 144227 [details]
Patch

Clearing flags on attachment: 144227

Committed r118689: <http://trac.webkit.org/changeset/118689>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.