Bug 87549

Summary: weakCompareAndSwap should work on Windows
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
jberlin: review+, buildbot: commit-queue-
attempt to actually make it build none

Filip Pizlo
Reported 2012-05-25 16:43:24 PDT
By using the InterlockedCompareExchange function.
Attachments
the patch (1.70 KB, patch)
2012-05-25 16:45 PDT, Filip Pizlo 		jberlin: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
attempt to actually make it build (1.78 KB, patch)
2012-05-25 17:11 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2012-05-25 16:45:02 PDT
Created attachment 144170 [details] the patch
Jessie Berlin
Comment 2 2012-05-25 16:51:02 PDT
Comment on attachment 144170 [details] the patch r=me (assuming this passes win EWS)
Filip Pizlo
Comment 3 2012-05-25 16:52:00 PDT
(In reply to comment #2) > (From update of attachment 144170 [details]) > r=me (assuming this passes win EWS) Thanks! Will await the greenness.
Build Bot
Comment 4 2012-05-25 17:07:13 PDT
Comment on attachment 144170 [details] the patch Attachment 144170 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12801605
Filip Pizlo
Comment 5 2012-05-25 17:11:20 PDT
Created attachment 144174 [details] attempt to actually make it build
WebKit Review Bot
Comment 6 2012-05-25 20:09:52 PDT
Comment on attachment 144174 [details] attempt to actually make it build Clearing flags on attachment: 144174 Committed r118603: <http://trac.webkit.org/changeset/118603>
WebKit Review Bot
Comment 7 2012-05-25 20:09:56 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 8 2012-05-26 17:16:17 PDT
Comment on attachment 144170 [details] the patch Windows EWS says: 2>c:\cygwin\home\buildbot\WebKit\Source\WTF\wtf/Atomics.h(124) : error C2664: 'InterlockedCompareExchange' : cannot convert parameter 1 from 'volatile unsigned int *' to 'volatile LONG *' Thus, I suspect we have a need for some type casting.
Darin Adler
Comment 9 2012-05-26 17:16:34 PDT
Oh, I see that was fixed before landing.
Note You need to log in before you can comment on or make changes to this bug.