Bug 87545

Summary: Support building the Android port of chromium with Ninja
Product: WebKit Reporter: Yaron Friedman <yfriedman>
Component: New BugsAssignee: Yaron Friedman <yfriedman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, thakis, wangxianzhu, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
none
Patch none

Yaron Friedman
Reported 2012-05-25 16:10:11 PDT
Support building the Android port of chromium with Ninja
Attachments
Patch (2.56 KB, patch)
2012-05-25 16:13 PDT, Yaron Friedman 		no flags
DetailsFormatted DiffDiff
Patch (2.57 KB, patch)
2012-05-25 16:23 PDT, Yaron Friedman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yaron Friedman
Comment 1 2012-05-25 16:13:20 PDT
Created attachment 144165 [details] Patch
WebKit Review Bot
Comment 2 2012-05-25 16:15:33 PDT
Attachment 144165 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/D..." exit_code: 1 Tools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Tools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2012-05-25 16:17:37 PDT
Looks like you've got some tabs in your ChangeLog. This looks plausible to me, but I don't actually know how this all works. Hopefully thakis can help. :)
Nico Weber
Comment 4 2012-05-25 16:19:15 PDT
LGTM. I'm not a fan of the ant_build_dir, but that's how android's doing it in chromium land too.
Yaron Friedman
Comment 5 2012-05-25 16:23:55 PDT
Created attachment 144167 [details] Patch
Yaron Friedman
Comment 6 2012-05-25 16:24:58 PDT
Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit?
Adam Barth
Comment 7 2012-05-25 16:43:24 PDT
> Fixed changelog. I'm gonna land the dependent change in chromium on Tuesday (don't want to hit the bit now) and then I guess wait for that to roll into webkit? Once your change lands in Chromium, you just need to edit this revision number: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/DEPS#L35 We typically just bump the number in a separate commit as needed. It usually goes smoothly, but if you have and trouble, feel free to ping me and we'll figure it out.
Yaron Friedman
Comment 8 2012-05-31 17:30:03 PDT
While I was doing something else, looks like other folks already rolled DEPS past my revision. Seems like this is ready to go.
Yaron Friedman
Comment 9 2012-05-31 17:32:06 PDT
I'm not a committer, though. Adam can you put it in the CQ?
WebKit Review Bot
Comment 10 2012-05-31 18:13:29 PDT
Comment on attachment 144167 [details] Patch Clearing flags on attachment: 144167 Committed r119183: <http://trac.webkit.org/changeset/119183>
WebKit Review Bot
Comment 11 2012-05-31 18:13:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.