Bug 87531

Summary: [Chromium] Move fileExists to Platform.h
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, haraken, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Followup patch none

Mark Pilgrim (Google)
Reported 2012-05-25 13:14:02 PDT
[Chromium] Move fileExists to Platform.h
Attachments
Patch (3.91 KB, patch)
2012-05-25 13:14 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2012-05-25 13:18 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (4.74 KB, patch)
2012-05-29 12:33 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Followup patch (2.51 KB, patch)
2012-05-29 19:40 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-05-25 13:14:50 PDT
Created attachment 144135 [details] Patch
WebKit Review Bot
Comment 2 2012-05-25 13:16:37 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
WebKit Review Bot
Comment 3 2012-05-25 13:16:55 PDT
Attachment 144135 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Pilgrim (Google)
Comment 4 2012-05-25 13:18:25 PDT
Created attachment 144137 [details] Patch
Adam Barth
Comment 5 2012-05-25 16:10:03 PDT
Comment on attachment 144137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144137&action=review > Source/WebKit/chromium/src/PlatformSupport.cpp:-305 > -bool PlatformSupport::fileExists(const String& path) Should we remove this from PlatformSupport.h as well?
Mark Pilgrim (Google)
Comment 6 2012-05-29 12:33:28 PDT
Created attachment 144601 [details] Patch
Mark Pilgrim (Google)
Comment 7 2012-05-29 12:43:53 PDT
Latest patch removes function declaration from PlatformSupport.h.
WebKit Review Bot
Comment 8 2012-05-29 18:34:08 PDT
Comment on attachment 144601 [details] Patch Clearing flags on attachment: 144601 Committed r118873: <http://trac.webkit.org/changeset/118873>
WebKit Review Bot
Comment 9 2012-05-29 18:34:16 PDT
All reviewed patches have been landed. Closing bug.
Mark Pilgrim (Google)
Comment 10 2012-05-29 19:33:20 PDT
Reopening per discussion with abarth in IRC.
Mark Pilgrim (Google)
Comment 11 2012-05-29 19:40:24 PDT
Created attachment 144682 [details] Followup patch
Mark Pilgrim (Google)
Comment 12 2012-05-29 19:42:02 PDT
Comment on attachment 144682 [details] Followup patch Call fileExists through fileUtilities(), not directly.
WebKit Review Bot
Comment 13 2012-05-29 22:10:52 PDT
Comment on attachment 144682 [details] Followup patch Clearing flags on attachment: 144682 Committed r118894: <http://trac.webkit.org/changeset/118894>
WebKit Review Bot
Comment 14 2012-05-29 22:10:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.