Bug 87523

Summary: Make RenderLayer not arena-allocated
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, esprehn+autocc, glenn, hyatt, jchaffraix, kling, kondapallykalyan, ojan, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 122651    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2012-05-25 11:42:06 PDT
We don't think we're getting any benefit from RenderLayer being arena-allocated, and it adds code complexity.
Attachments
Patch (4.96 KB, patch)
2013-10-11 01:14 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2012-05-25 12:12:04 PDT
Agreed!
Ojan Vafai
Comment 2 2012-05-25 12:21:19 PDT
How is RenderLayer different than the other Render* classes WRT usefulness of being arena-allocated?
Simon Fraser (smfr)
Comment 3 2012-05-25 12:47:00 PDT
There don't tend to be that many RenderLayers on most pages (tens - hundreds, not thousands).
Ojan Vafai
Comment 4 2012-05-25 13:03:17 PDT
Fair enough.
Andreas Kling
Comment 5 2013-10-11 01:14:29 PDT
Created attachment 213975 [details] Patch
WebKit Commit Bot
Comment 6 2013-10-11 02:37:57 PDT
Comment on attachment 213975 [details] Patch Clearing flags on attachment: 213975 Committed r157297: <http://trac.webkit.org/changeset/157297>
WebKit Commit Bot
Comment 7 2013-10-11 02:37:59 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 8 2013-10-11 09:49:08 PDT
Re-opened since this is blocked by bug 122651
Alexey Proskuryakov
Comment 9 2013-10-11 09:53:46 PDT
This caused crashes on tests (debug and release WK2). Very strange that EWS didn't catch it, was the landed patch identical to the one posted here? Rolled out in <https://trac.webkit.org/r157306>. Results: http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r157297%20(13299)/results.html
Andreas Kling
Comment 10 2013-10-12 02:14:09 PDT
Committed r157333: <http://trac.webkit.org/changeset/157333>
Note You need to log in before you can comment on or make changes to this bug.