Bug 87519

Summary:

Turn on Regions for Apple Windows port

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

CSS

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, hyatt, jberlin, mibalan, mihnea, roger_fong, sfalken, thorton, webkit-bug-importer, WebkitBugTracker, webkit.review.bot, zoltan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

113262

Bug Blocks:

Attachments:

Description	Flags
patch	mitz: review+, buildbot: commit-queue-
patch	thorton: review+

Tim Horton

Reported 2012-05-25 11:21:46 PDT

After http://trac.webkit.org/changeset/118484

Attachments
patch (1.14 KB, patch) 2012-05-25 11:23 PDT, Tim Horton	mitz: review+ buildbot: commit-queue-	Details Formatted Diff Diff
patch (8.34 KB, patch) 2013-03-25 13:50 PDT, Roger Fong	thorton: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2012-05-25 11:22:37 PDT

<rdar://problem/11535700>

Tim Horton

Comment 2 2012-05-25 11:23:01 PDT

Created attachment 144107 [details] patch

Tim Horton

Comment 3 2012-05-25 11:56:18 PDT

O...kay... 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(287) : error C2065: 'CSSPropertyWebkitShapeInside' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(288) : error C2065: 'CSSPropertyWebkitShapeOutside' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(315) : error C2065: 'CSSPropertyWebkitFlowInto' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(316) : error C2065: 'CSSPropertyWebkitFlowFrom' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(317) : error C2065: 'CSSPropertyWebkitRegionOverflow' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(318) : error C2065: 'CSSPropertyWebkitRegionBreakAfter' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(319) : error C2065: 'CSSPropertyWebkitRegionBreakBefore' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(320) : error C2065: 'CSSPropertyWebkitRegionBreakInside' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(323) : error C2065: 'CSSPropertyWebkitWrapFlow' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(324) : error C2065: 'CSSPropertyWebkitWrapMargin' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(325) : error C2065: 'CSSPropertyWebkitWrapPadding' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(326) : error C2065: 'CSSPropertyWebkitWrapThrough' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1601) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1603) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(1605) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2324) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2328) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2332) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2336) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2338) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2340) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2342) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2346) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2350) : error C2051: case expression not constant 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2484) : error C2065: 'CSSPropertyWebkitWrap' : undeclared identifier 7>c:\cygwin\home\buildbot\webkit\source\webcore\css\CSSComputedStyleDeclaration.cpp(2484) : error C2051: case expression not constant

Build Bot

Comment 4 2012-05-25 11:57:08 PDT

Comment on attachment 144107 [details] patch Attachment 144107 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12802509

Tim Horton

Comment 5 2012-05-25 13:06:46 PDT

I get very similar errors if I flip the setting and don't do a clean build on mac. I'll have to manually verify this at some point, probably not today.

Tim Horton

Comment 6 2012-06-13 15:47:57 PDT

*** This bug has been marked as a duplicate of bug 88645 ***

Roger Fong

Comment 7 2013-03-25 13:50:02 PDT

Created attachment 194918 [details] patch

Tim Horton

Comment 8 2013-03-25 13:54:00 PDT

Comment on attachment 194918 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=194918&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:13813 > <File > - RelativePath="$(ConfigurationBuildDir)\obj\WebCore\DerivedSources\JSShadowRoot.cpp" > + RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSecurityPolicyViolationEvent.cpp" > > > <FileConfiguration > Name="Debug|Win32" This looks unexpected.

WebKit Review Bot

Comment 9 2013-03-25 18:39:30 PDT

Re-opened since this is blocked by bug 113262

Mihai Balan

Comment 10 2013-05-17 05:29:25 PDT

There is a Windows port no more :)

Roger Fong

Comment 11 2013-05-17 11:42:48 PDT

There is a windows port...we're maintaining it

Zoltan Horvath

Comment 12 2014-02-07 14:17:56 PST

Removing Exclusions/Shapes from the bug title, since it's been enabled in http://trac.webkit.org/changeset/160200

Brent Fulgham

Comment 13 2016-03-22 14:20:02 PDT

All of this is on an active in Windows.

Note You need to log in before you can comment on or make changes to this bug.