Bug 87512

Summary: Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Vsevolod Vlasov 2012-05-25 10:41:44 PDT 
Patch to follow
Comment 1 Vsevolod Vlasov 2012-05-25 10:44:41 PDT 
Created attachment 144099 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-05-25 10:45:11 PDT 
This might need some polish before landing, but overall, folks, what do you think?
Comment 3 WebKit Review Bot 2012-05-25 10:47:04 PDT 
Attachment 144099 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/generate_protocol_externs.py:7:  trailing whitespace  [pep8/W291] [5]
Source/WebCore/inspector/generate_protocol_externs.py:17:  trailing whitespace  [pep8/W291] [5]
Source/WebCore/inspector/generate_protocol_externs.py:37:  whitespace before '}'  [pep8/E202] [5]
Source/WebCore/inspector/generate_protocol_externs.py:42:  expected 2 blank lines, found 1  [pep8/E302] [5]
Source/WebCore/inspector/generate_protocol_externs.py:44:  indentation is not a multiple of four  [pep8/E111] [5]
Source/WebCore/inspector/generate_protocol_externs.py:46:  trailing whitespace  [pep8/W291] [5]
Source/WebCore/inspector/generate_protocol_externs.py:47:  expected 2 blank lines, found 1  [pep8/E302] [5]
Source/WebCore/inspector/generate_protocol_externs.py:62:  expected 2 blank lines, found 1  [pep8/E302] [5]
Source/WebCore/inspector/generate_protocol_externs.py:72:  whitespace before ')'  [pep8/E202] [5]
Source/WebCore/inspector/generate_protocol_externs.py:130:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Source/WebCore/inspector/generate_protocol_externs.py:150:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Source/WebCore/inspector/generate_protocol_externs.py:152:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 12 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yury Semikhatsky 2012-05-27 23:26:36 PDT 
Comment on attachment 144099 [details]
Patch

Looks good.
Comment 5 Yury Semikhatsky 2012-05-27 23:27:29 PDT 
(In reply to comment #4)
> (From update of attachment 144099 [details])
> Looks good.

Please fix style warnings before landing.
Comment 6 Vsevolod Vlasov 2012-06-06 04:37:17 PDT 
Committed r119585: <http://trac.webkit.org/changeset/119585>