Bug 87505 – Add a != operator to ViewportArguments

• Component: DOM
• Status: RESOLVED FIXED

[Jacky Jiang]

As suggested on bug 87438, we should add a != operator to ViewportArguments.
Hopefully this is right thing to do. Open for discussions in case there are different ideas.

[Kenneth Rohde Christiansen]

You should explain better why that it needed. I actually believe that we used to have that.

[Antonio Gomes]

I think it is only about convenience.

in blackberry/ we have 3 or 4 cases of

if (!(m_viewportArgument == DefaultViewportArguments)) {
...
}

[Antonio Gomes]

Any update here? Looks straightforward and useful...

[Jacky Jiang]

(In reply to comment #3)
> Any update here? Looks straightforward and useful...
I will update this. Assign to myself.

[Jacky Jiang]

Created attachment 148632 [details]
Patch

[Konrad Piascik]

Comment on attachment 148632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148632&action=review

> Source/WebCore/dom/ViewportArguments.h:111
> +    bool operator!=(const ViewportArguments& other) const

You don't want this duplicated code.  What you should do is this:
return !(this == other);

[Jacky Jiang]

Comment on attachment 148632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=148632&action=review

>> Source/WebCore/dom/ViewportArguments.h:111
>> +    bool operator!=(const ViewportArguments& other) const
> 
> You don't want this duplicated code.  What you should do is this:
> return !(this == other);

Thanks, should be this !(*this == other) if we don't want duplicate this code I think.

[Jacky Jiang]

Created attachment 148644 [details]
Patch

[Jacky Jiang]

Comment on attachment 148644 [details]
Patch

Committed r120874: <http://trac.webkit.org/changeset/120874>