Bug 87490

Summary:

Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Web Inspector (Deprecated)

Assignee:

Ilya Tikhonovsky <loislo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, alph, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Ilya Tikhonovsky

Reported 2012-05-25 04:53:08 PDT

Originally WebInspector.Uint32Array was used for dynamic array reallocation because we had no information about expected arrays sizes. Now we have these sizes and allocates array precisely.

Attachments
Patch (5.33 KB, patch) 2012-05-25 04:57 PDT, Ilya Tikhonovsky	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2012-05-25 04:55:05 PDT

before: RESULT heap-snapshot: transfer-snapshot= 1809 ms after: RESULT heap-snapshot: transfer-snapshot= 1530 ms

Ilya Tikhonovsky

Comment 2 2012-05-25 04:57:34 PDT

Created attachment 144046 [details] Patch

Yury Semikhatsky

Comment 3 2012-05-25 05:01:11 PDT

Comment on attachment 144046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=144046&action=review > Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:156 > var node_fields_count = this._snapshot.snapshot.meta.node_fields.length; node_fields_count -> nodeFieldCount > Source/WebCore/inspector/front-end/HeapSnapshotLoader.js:157 > var nodes_length = this._snapshot.snapshot.node_count * node_fields_count; nodes_length -> nodeLength

Ilya Tikhonovsky

Comment 4 2012-05-25 06:42:56 PDT

Committed r118521: <http://trac.webkit.org/changeset/118521>

Note You need to log in before you can comment on or make changes to this bug.