Bug 87471

Summary: [EFL][DRT] Gardening. fast/events/option-tab.html does not pass
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch v2 (corrected bug title in changelog) none

Mikhail Pozdnyakov
Reported 2012-05-25 01:20:58 PDT
fast/events/option-tab.html was erroneously unskipped with r118404. Should not pass as the EFL port uses different keyboard accelerators than Safari.
Attachments
patch (1.58 KB, patch)
2012-05-25 01:25 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
patch v2 (corrected bug title in changelog) (1.58 KB, patch)
2012-05-25 01:36 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-05-25 01:25:18 PDT
Created attachment 144003 [details] patch
Thiago Marcos P. Santos
Comment 2 2012-05-25 01:28:46 PDT
(In reply to comment #1) > Created an attachment (id=144003) [details] > patch Why this patch was tagged as [GTK]?
Mikhail Pozdnyakov
Comment 3 2012-05-25 01:29:30 PDT
(In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=144003) [details] [details] > > patch > > Why this patch was tagged as [GTK]? ooops..
Thiago Marcos P. Santos
Comment 4 2012-05-25 01:31:21 PDT
Comment on attachment 144003 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > LayoutTests/platform/efl/test_expectations.txt:115 > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). I don't get this comment.
Mikhail Pozdnyakov
Comment 5 2012-05-25 01:36:24 PDT
Created attachment 144005 [details] patch v2 (corrected bug title in changelog)
Mikhail Pozdnyakov
Comment 6 2012-05-25 01:56:10 PDT
(In reply to comment #4) > (From update of attachment 144003 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > > > LayoutTests/platform/efl/test_expectations.txt:115 > > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). > > I don't get this comment. From the test case description: <p>This tests that option-tab moves you from a text field to a link, but plain old tab does not.</p> <p>Note: Option is the Mac name for what other platforms call Alt.</p> Other platforms do not have such behavior. (See also other ports test expectations).
WebKit Review Bot
Comment 7 2012-05-25 02:41:31 PDT
Comment on attachment 144005 [details] patch v2 (corrected bug title in changelog) Clearing flags on attachment: 144005 Committed r118502: <http://trac.webkit.org/changeset/118502>
WebKit Review Bot
Comment 8 2012-05-25 02:41:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.