Summary: | [EFL][DRT] Gardening. fast/events/option-tab.html does not pass | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Component: | WebKit EFL | Assignee: | Mikhail Pozdnyakov <mikhail.pozdnyakov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, tmpsantos, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Mikhail Pozdnyakov
2012-05-25 01:20:58 PDT
Created attachment 144003 [details]
patch
(In reply to comment #1) > Created an attachment (id=144003) [details] > patch Why this patch was tagged as [GTK]? (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=144003) [details] [details] > > patch > > Why this patch was tagged as [GTK]? ooops.. Comment on attachment 144003 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > LayoutTests/platform/efl/test_expectations.txt:115 > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). I don't get this comment. Created attachment 144005 [details]
patch v2 (corrected bug title in changelog)
(In reply to comment #4) > (From update of attachment 144003 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144003&action=review > > > LayoutTests/platform/efl/test_expectations.txt:115 > > +// The EFL port uses different keyboard accelerators than Safari (via Chromium). > > I don't get this comment. From the test case description: <p>This tests that option-tab moves you from a text field to a link, but plain old tab does not.</p> <p>Note: Option is the Mac name for what other platforms call Alt.</p> Other platforms do not have such behavior. (See also other ports test expectations). Comment on attachment 144005 [details] patch v2 (corrected bug title in changelog) Clearing flags on attachment: 144005 Committed r118502: <http://trac.webkit.org/changeset/118502> All reviewed patches have been landed. Closing bug. |