Bug 87462

Summary: Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: CSSAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, dglazkov, eric, macpherson, menard, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85580    
Attachments:
Description Flags
Patch
none
Patch for landing none

Luke Macpherson
Reported 2012-05-24 22:23:45 PDT
Use StringBuilder in WebKitCSSTransformValue::customCssText() to allow code reuse with CSS Variables.
Attachments
Patch (4.72 KB, patch)
2012-05-24 22:27 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.85 KB, patch)
2012-05-27 17:17 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-05-24 22:27:38 PDT
Created attachment 143977 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2012-05-25 08:58:01 PDT
Comment on attachment 143977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143977&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:70 > + if (m_type != UnknownTransformOperation) { Do we need to ASSERT the expected range of m_type somewhere around here?
Luke Macpherson
Comment 3 2012-05-27 17:17:43 PDT
Created attachment 144254 [details] Patch for landing
WebKit Review Bot
Comment 4 2012-05-27 18:53:35 PDT
Comment on attachment 144254 [details] Patch for landing Clearing flags on attachment: 144254 Committed r118639: <http://trac.webkit.org/changeset/118639>
WebKit Review Bot
Comment 5 2012-05-27 18:53:40 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2012-05-27 20:39:27 PDT
Comment on attachment 144254 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > +const int transformNameSize = 22; Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us. > Source/WebCore/css/WebKitCSSTransformValue.cpp:38 > + "", Why "" instead of 0 here?
Luke Macpherson
Comment 7 2012-05-27 22:00:21 PDT
(In reply to comment #6) > (From update of attachment 144254 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=144254&action=review > > > Source/WebCore/css/WebKitCSSTransformValue.cpp:36 > > +const int transformNameSize = 22; > > Seems a shame to hard-code that 22 value when we have WTF_ARRAY_LENGTH to compute such things for us. > > > Source/WebCore/css/WebKitCSSTransformValue.cpp:38 > > + "", > > Why "" instead of 0 here? Fair points, I'll post a follow-up patch.
Note You need to log in before you can comment on or make changes to this bug.