Bug 87442

Summary:

Add feature defines for web-facing parts of CSS Regions and Exclusions

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

CSS

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cmarcelo, gustavo, macpherson, menard, mitz, ojan, ossy, philn, webkit.review.bot, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	none
patch	mitz: review+, buildbot: commit-queue-
patch for landing if windows builds	none
gtk	none

Tim Horton

Reported 2012-05-24 17:03:38 PDT

The runtime flag and setting for Regions and Exclusions are insufficient to actually disable all web-facing aspects of these features. <rdar://problem/10887709>

Attachments
patch (66.48 KB, patch) 2012-05-24 17:57 PDT, Tim Horton	no flags	Details Formatted Diff Diff
patch (66.64 KB, patch) 2012-05-24 18:00 PDT, Tim Horton	no flags	Details Formatted Diff Diff
patch (66.95 KB, patch) 2012-05-24 18:17 PDT, Tim Horton	mitz: review+ buildbot: commit-queue-	Details Formatted Diff Diff
patch for landing if windows builds (67.53 KB, patch) 2012-05-24 20:02 PDT, Tim Horton	no flags	Details Formatted Diff Diff
gtk (69.80 KB, patch) 2012-05-24 20:20 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2012-05-24 17:57:34 PDT

Created attachment 143939 [details] patch

Tim Horton

Comment 2 2012-05-24 18:00:36 PDT

Created attachment 143940 [details] patch

Tim Horton

Comment 3 2012-05-24 18:07:17 PDT

Rebase time.

Tim Horton

Comment 4 2012-05-24 18:17:25 PDT

Created attachment 143943 [details] patch

Build Bot

Comment 5 2012-05-24 18:48:45 PDT

Comment on attachment 143943 [details] patch Attachment 143943 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12798350

mitz

Comment 6 2012-05-24 18:59:31 PDT

Comment on attachment 143943 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=143943&action=review r+ but you need to figure out why this is breaking Windows > Source/WebCore/ChangeLog:9 > + No new tests. Either explain why there are no new tests, if you think it’s necessary, or just remove this line. If no tests are listed here, then there are no new tests! > Source/WebCore/bindings/objc/DOMCSS.mm:55 > +#if ENABLE(CSS_REGIONS) > #import "DOMWebKitCSSRegionRule.h" > +#endif We don’t stick #if directives into the main #import or #include block. You should create a separate section with just this #import. This comment applies to the rest of this patch.

Tim Horton

Comment 7 2012-05-24 20:02:39 PDT

Created attachment 143954 [details] patch for landing if windows builds

Tim Horton

Comment 8 2012-05-24 20:20:40 PDT

Created attachment 143957 [details] gtk

Tim Horton

Comment 9 2012-05-24 23:54:09 PDT

Landed in http://trac.webkit.org/changeset/118484

Csaba Osztrogonác

Comment 10 2012-05-25 01:45:35 PDT

(In reply to comment #9) > Landed in http://trac.webkit.org/changeset/118484 Enabled on Qt again: http://trac.webkit.org/changeset/118494

Note You need to log in before you can comment on or make changes to this bug.