Bug 87419

Summary:

[BlackBerry] Implement select popup and remove old hook to air popup

Product:

WebKit

Reporter:

Crystal Zhang <haizhang>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rakuco, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
updated patch	none

Description Crystal Zhang 2012-05-24 13:06:47 PDT

Implement select popup client and remove the old hook for air popup.

Comment 1 Crystal Zhang 2012-05-24 13:22:25 PDT

Created attachment 143877 [details]
patch

Comment 2 Crystal Zhang 2012-05-24 14:36:40 PDT

Created attachment 143899 [details]
updated patch

Comment 3 Rob Buis 2012-05-24 14:57:43 PDT

Comment on attachment 143899 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143899&action=review

Looks good.

> Source/WebCore/Resources/blackberry/popupControlBlackBerry.css:66
> +}

I think this could have been placed in WebCore/css too, but this works as well.

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147
> +        const WTF::Vector<HTMLElement*>& items = m_element->listItems();

You do not need the WTF:: prefix.

Comment 4 WebKit Review Bot 2012-05-24 15:33:31 PDT

Comment on attachment 143899 [details]
updated patch

Clearing flags on attachment: 143899

Committed r118436: <http://trac.webkit.org/changeset/118436>

Comment 5 WebKit Review Bot 2012-05-24 15:33:35 PDT

All reviewed patches have been landed.  Closing bug.