Bug 87419

Summary: [BlackBerry] Implement select popup and remove old hook to air popup
Product: WebKit Reporter: Crystal Zhang <haizhang>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
updated patch none

Crystal Zhang
Reported 2012-05-24 13:06:47 PDT
Implement select popup client and remove the old hook for air popup.
Attachments
patch (26.08 KB, patch)
2012-05-24 13:22 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
updated patch (26.01 KB, patch)
2012-05-24 14:36 PDT, Crystal Zhang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Crystal Zhang
Comment 1 2012-05-24 13:22:25 PDT
Created attachment 143877 [details] patch
Crystal Zhang
Comment 2 2012-05-24 14:36:40 PDT
Created attachment 143899 [details] updated patch
Rob Buis
Comment 3 2012-05-24 14:57:43 PDT
Comment on attachment 143899 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=143899&action=review Looks good. > Source/WebCore/Resources/blackberry/popupControlBlackBerry.css:66 > +} I think this could have been placed in WebCore/css too, but this works as well. > Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:147 > + const WTF::Vector<HTMLElement*>& items = m_element->listItems(); You do not need the WTF:: prefix.
WebKit Review Bot
Comment 4 2012-05-24 15:33:31 PDT
Comment on attachment 143899 [details] updated patch Clearing flags on attachment: 143899 Committed r118436: <http://trac.webkit.org/changeset/118436>
WebKit Review Bot
Comment 5 2012-05-24 15:33:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.