Bug 87412

Summary:

[BlackBerry] InputHandler can hold a ref on an object when document is cleared.

Product:

WebKit

Reporter:

Mike Fenton <mifenton>

Component:

WebKit BlackBerry

Assignee:

Mike Fenton <mifenton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rwlbuis: review+, webkit.review.bot: commit-queue-
Updated Patch	none

Mike Fenton

Reported 2012-05-24 11:55:10 PDT

InputHandler can hold onto a Refptr for an element within a document after the document is cleared. We need to notify InputHandler of a frame removal to clear state when WebPage::clearDocumentData is called.

Attachments
Patch (2.32 KB, patch) 2012-05-24 11:58 PDT, Mike Fenton	rwlbuis: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Updated Patch (2.23 KB, patch) 2012-05-24 13:17 PDT, Mike Fenton	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mike Fenton

Comment 1 2012-05-24 11:58:32 PDT

Created attachment 143866 [details] Patch

Rob Buis

Comment 2 2012-05-24 12:01:39 PDT

Comment on attachment 143866 [details] Patch Looks good.

WebKit Review Bot

Comment 3 2012-05-24 12:49:51 PDT

Comment on attachment 143866 [details] Patch Rejecting attachment 143866 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 37 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 37. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/12791290

WebKit Review Bot

Comment 4 2012-05-24 13:13:45 PDT

Comment on attachment 143866 [details] Patch Rejecting attachment 143866 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: '--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/blackberry/Api/WebPage.cpp patching file Source/WebKit/blackberry/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/ChangeLog.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12791296

Mike Fenton

Comment 5 2012-05-24 13:17:40 PDT

Created attachment 143875 [details] Updated Patch

WebKit Review Bot

Comment 6 2012-05-24 15:38:03 PDT

Comment on attachment 143875 [details] Updated Patch Clearing flags on attachment: 143875 Committed r118438: <http://trac.webkit.org/changeset/118438>

WebKit Review Bot

Comment 7 2012-05-24 15:38:07 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.