Bug 87410

Summary: REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: DOMAssignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, jberlin, jhoneycutt, sfalken, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: Windows 7   
Attachments:
Description Flags
Patch none

Jessie Berlin
Reported 2012-05-24 11:41:01 PDT
http://trac.webkit.org/changeset/109663 explicitly ignored the comment in LocalizedStrings.cpp: // Note that because |format| is used as the second parameter to va_start, it cannot be a reference // type according to section 18.7/3 of the C++ N1905 standard. and changed the parameter to a const reference. This caused crashes under CFStringCreateWithFormatAndArguments on Windows.
Attachments
Patch (1.36 KB, patch)
2012-05-24 11:44 PDT, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2012-05-24 11:44:36 PDT
Created attachment 143863 [details] Patch
Jessie Berlin
Comment 2 2012-05-24 12:00:25 PDT
Comment on attachment 143863 [details] Patch Committed in http://trac.webkit.org/changeset/118399
Radar WebKit Bug Importer
Comment 3 2012-05-24 12:41:40 PDT
<rdar://problem/11527190>
Note You need to log in before you can comment on or make changes to this bug.