Summary: | Text Autosizing: Add compile flag and runtime setting | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Mellor <johnme> | ||||||||||||||
Component: | Text | Assignee: | John Mellor <johnme> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Enhancement | CC: | abarth, ashwinkumare994, dglazkov, efidler, fishd, jamesr, mitz, peter, simon.fraser, tkent+wkapi, vestbo, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Bug Depends on: | |||||||||||||||||
Bug Blocks: | 84186 | ||||||||||||||||
Attachments: |
|
Description
John Mellor
2012-05-24 08:11:47 PDT
Created attachment 143838 [details]
Patch
Comment on attachment 143838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143838&action=review Except for windows, looks fine. > Source/WebKit/chromium/features.gypi:146 > + 'ENABLE_FONT_BOOSTING=1', # TODO: CHECK THIS Check this? > WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:101 > + Value="ENABLE_FONT_BOOSTING" I doubt Windows wants this on. :) > WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:101 > + Value="ENABLE_FONT_BOOSTING" Similarly I suspect WinCairo wants it off. Created attachment 143839 [details]
Patch
Comment on attachment 143839 [details]
Patch
LGTM.
Comment on attachment 143839 [details] Patch Rejecting attachment 143839 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: aries/win/tools/vsprops/FeatureDefines.vsprops.rej patching file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops Hunk #1 FAILED at 9. Hunk #2 succeeded at 102 (offset 5 lines). 1 out of 2 hunks FAILED -- saving rejects to file WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops.rej patching file configure.ac Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12807160 @johnme: I can land this manually for you. (In reply to comment #6) > @johnme: I can land this manually for you. Thanks Adam. For future reference, what's the easiest way of rebasing a patch (preferably one that automatically resolves ChangeLogs)? I couldn't see any options for that on webkit-patch. > Thanks Adam. For future reference, what's the easiest way of rebasing a patch (preferably one that automatically resolves ChangeLogs)? I couldn't see any options for that on webkit-patch.
It depends if you're using git or svn. If you're using git, there's merge.changelog.driver. If you're using SVN, then update-webkit and/or resolve-ChangeLogs works well.
Created attachment 143862 [details]
Patch
Comment on attachment 143862 [details]
Patch
Forwarding Eric's r+
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. Comment on attachment 143862 [details] Patch Clearing flags on attachment: 143862 Committed r118407: <http://trac.webkit.org/changeset/118407> All reviewed patches have been landed. Closing bug. Reopening bug since Simon Fraser asked to rename Font Boosting to Text Autosizing in bug 88655. Created attachment 150752 [details]
Rename
Renames Font Boosting to Text Autosizing
Created attachment 150788 [details]
Rename and add compile guards
Renames Font Boosting to Text Autosizing. Also adds compile guards around the runtime settings.
Created attachment 150791 [details]
Rename and add compile guards
Renames Font Boosting to Text Autosizing (now sorted in correct order). Also adds compile guards around the runtime settings.
Comment on attachment 150791 [details] Rename and add compile guards Clearing flags on attachment: 150791 Committed r121861: <http://trac.webkit.org/changeset/121861> All reviewed patches have been landed. Closing bug. |