Bug 8734

Summary: Would like a Vector::append that takes another Vector
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: Web Template FrameworkAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 6638    
Attachments:
Description Flags
Implement function mjs: review+

Anders Carlsson
Reported 2006-05-04 11:02:59 PDT
The xpath implementation uses a lot of Vectors for keeping track of node sets. It'd be nice to have an append function that takes another Vector as this it's something that's done commonly in the xpath code
Attachments
Implement function (1.47 KB, patch)
2006-05-04 11:07 PDT, Anders Carlsson 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2006-05-04 11:07:03 PDT
Created attachment 8107 [details] Implement function This function works for me, but I'm not sure how correct it is. It doesn't support appending the vector to itself, but I don't know if we need that
Maciej Stachowiak
Comment 2 2006-05-04 13:17:19 PDT
Comment on attachment 8107 [details] Implement function Looks good to me. A more general version that takes start and end iterator might also be handy (and could be used to implement this one.
Note You need to log in before you can comment on or make changes to this bug.