Bug 87335

Summary: sort the array 'non_wrapper_types'
Product: WebKit Reporter: Lu Guanqun <guanqun.lu>
Component: New BugsAssignee: Lu Guanqun <guanqun.lu>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Lu Guanqun 2012-05-23 19:49:27 PDT 
sort the array 'non_wrapper_types'
Comment 1 Lu Guanqun 2012-05-23 19:50:26 PDT 
Created attachment 143710 [details]
Patch
Comment 2 Lu Guanqun 2012-05-23 19:51:11 PDT 
It's done via 'sort' command in Vim. Only few key strokes. :)
Comment 3 Kentaro Hara 2012-05-23 19:56:25 PDT 
Comment on attachment 143710 [details]
Patch

Looks good. If you want to have the patch be reviewed, please change "r" to "r?".
Comment 4 WebKit Review Bot 2012-05-23 20:46:53 PDT 
Comment on attachment 143710 [details]
Patch

Attachment 143710 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12794062
Comment 5 Lu Guanqun 2012-05-23 21:12:47 PDT 
Created attachment 143722 [details]
Patch
Comment 6 Kentaro Hara 2012-05-23 21:15:36 PDT 
Comment on attachment 143722 [details]
Patch

OK.

Please change "cq" to "cq?" if you want to commit it. Then I can change "cq?" to "cq+".
Comment 7 WebKit Review Bot 2012-05-23 22:24:02 PDT 
Comment on attachment 143722 [details]
Patch

Clearing flags on attachment: 143722

Committed r118322: <http://trac.webkit.org/changeset/118322>
Comment 8 WebKit Review Bot 2012-05-23 22:24:14 PDT 
All reviewed patches have been landed.  Closing bug.