Summary: | REGRESSION (115573): Incorrect rounding of margins for floats | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, dglazkov, dharani, eric, leviw, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 87338 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Emil A Eklund
2012-05-23 16:31:52 PDT
Created attachment 143683 [details]
Patch
Comment on attachment 143683 [details]
Patch
LGTM.
Thanks for the quick review Eric! Comment on attachment 143683 [details] Patch Clearing flags on attachment: 143683 Committed r118297: <http://trac.webkit.org/changeset/118297> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 87338 Created attachment 143868 [details]
Patch
Would you mind taking another look Eric? It's basically the same change as before but with a slightly different reference html file. Comment on attachment 143868 [details]
Patch
LGTM.
Comment on attachment 143868 [details] Patch Attachment 143868 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12805252 New failing tests: fast/block/float/floats-with-margin-should-not-wrap.html Created attachment 143895 [details]
Archive of layout-test-results from ec2-cr-linux-04
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 143924 [details]
Patch for landing
Committed r118448: <http://trac.webkit.org/changeset/118448> |