Bug 87309

Summary: Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Trivial CC: schenney, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Avoid expensive determineAnimatedPropertyType call
none
Fixed changelog none

Philip Rogers
Reported 2012-05-23 13:52:30 PDT
This is a minor refactor of SVGAnimateTransformElement::hasValidAttributeType() to use m_animatedPropertyType instead of computing it on the fly. This same optimization was done in https://bugs.webkit.org/show_bug.cgi?id=75096 for SVGAnimateElement. Patch forthcoming.
Attachments
Avoid expensive determineAnimatedPropertyType call (2.41 KB, patch)
2012-05-23 14:05 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Fixed changelog (2.41 KB, patch)
2012-05-23 14:07 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-05-23 14:05:32 PDT
Created attachment 143646 [details] Avoid expensive determineAnimatedPropertyType call
Philip Rogers
Comment 2 2012-05-23 14:07:15 PDT
Created attachment 143648 [details] Fixed changelog
Nikolas Zimmermann
Comment 3 2012-05-23 23:44:30 PDT
Comment on attachment 143648 [details] Fixed changelog Good idea, r=me!
WebKit Review Bot
Comment 4 2012-05-24 08:30:24 PDT
Comment on attachment 143648 [details] Fixed changelog Clearing flags on attachment: 143648 Committed r118379: <http://trac.webkit.org/changeset/118379>
WebKit Review Bot
Comment 5 2012-05-24 08:30:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.