Bug 87293

Summary: [EFL] Update test expectations for layout test fast/events/click-focus-anchor.html
Product: WebKit Reporter: Alexander Shalamov <alexander.shalamov>
Component: WebKit EFLAssignee: Alexander Shalamov <alexander.shalamov>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, jussi.kukkonen, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alexander Shalamov
Reported 2012-05-23 11:52:04 PDT
Anchor element is mouse focusable for QT, GTK and EFL ports, therefore, test expectations file need to be updated.
Attachments
Patch (1.29 KB, patch)
2012-05-23 12:03 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2012-05-23 12:23 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Patch (5.41 KB, patch)
2012-05-23 22:40 PDT, Alexander Shalamov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Shalamov
Comment 1 2012-05-23 12:03:57 PDT
Created attachment 143611 [details] Patch added platform specific test expectation
Alexander Shalamov
Comment 2 2012-05-23 12:23:13 PDT
Created attachment 143614 [details] Patch Unskip test
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-05-23 12:34:17 PDT
Comment on attachment 143614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143614&action=review > LayoutTests/platform/efl/fast/events/click-focus-anchor-expected.txt:3 > +The expected result is platform specific. GTK and QT allows all links to be mouse focusable. I'd change the actual test to mention EFL here as well (applies to the "a3" line below too).
Alexander Shalamov
Comment 4 2012-05-23 22:40:45 PDT
Created attachment 143734 [details] Patch Made changes according to review comments
Eric Seidel (no email)
Comment 5 2012-05-24 09:26:18 PDT
Comment on attachment 143734 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143734&action=review > LayoutTests/fast/events/click-focus-anchor-expected.txt:3 > +The expected result is platform specific. GTK, QT and EFL allows all links to be mouse focusable. I would have changed this to say "some platforms", as some future platform may want this behavior or not. :)
WebKit Review Bot
Comment 6 2012-05-24 10:23:36 PDT
Comment on attachment 143734 [details] Patch Clearing flags on attachment: 143734 Committed r118390: <http://trac.webkit.org/changeset/118390>
WebKit Review Bot
Comment 7 2012-05-24 10:23:42 PDT
All reviewed patches have been landed. Closing bug.
Jussi Kukkonen (jku)
Comment 8 2012-05-28 01:43:11 PDT
*** Bug 87090 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.