Bug 87270

Summary: Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2012-05-23 09:27:14 PDT
WebInspector.RawLocation will eventually become generic raw location independent from concrete domain (Styles, Debugger).
Attachments
Patch (37.16 KB, patch)
2012-05-23 09:34 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (34.19 KB, patch)
2012-05-25 09:04 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (34.19 KB, patch)
2012-06-06 10:07 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-05-23 09:34:45 PDT
Created attachment 143582 [details] Patch
Pavel Feldman
Comment 2 2012-05-23 11:30:22 PDT
Comment on attachment 143582 [details] Patch Lets declare RawLocation as an empty interface instead.
Vsevolod Vlasov
Comment 3 2012-05-25 09:04:41 PDT
Created attachment 144079 [details] Patch
Vsevolod Vlasov
Comment 4 2012-06-06 10:07:37 PDT
Created attachment 146055 [details] Patch
Pavel Feldman
Comment 5 2012-06-09 03:47:32 PDT
Comment on attachment 146055 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146055&action=review > Source/WebCore/inspector/front-end/DebuggerModel.js:218 > + var rawLocation = /** @type {WebInspector.DebuggerModel.Location} */ location; There is no need for this cast > Source/WebCore/inspector/front-end/UISourceCode.js:434 > +WebInspector.RawLocation = function() Could you remind me why this one does not have lineNumber, columnNumber members?
Vsevolod Vlasov
Comment 6 2012-06-09 04:15:00 PDT
> > Source/WebCore/inspector/front-end/UISourceCode.js:434 > > +WebInspector.RawLocation = function() > > Could you remind me why this one does not have lineNumber, columnNumber members? There is no way to add a field to compiler interface.
Vsevolod Vlasov
Comment 7 2012-06-09 04:24:05 PDT
Committed r119898: <http://trac.webkit.org/changeset/119898>
Note You need to log in before you can comment on or make changes to this bug.