| Summary: | Change EFL debug build name with more detail one | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Component: | Tools / Tests | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | d-r, rniwa, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Gyuyoung Kim
2012-05-23 05:47:40 PDT
Created attachment 143548 [details]
Patch
CC'ing Ryosuke, Dominik Comment on attachment 143548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143548&action=review > Tools/ChangeLog:10 > + In addition, though nobody triggers EFL debug buildbot, EFL debug buildbot is registered > + as trigerable bot. This sounds as if you're making it triggerable now. Please revise it something like "In addition, remove efl-linux-debug triggerable since nobody uses it". Created attachment 143705 [details]
Patch
(In reply to comment #3) > (From update of attachment 143548 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143548&action=review > > > Tools/ChangeLog:10 > > + In addition, though nobody triggers EFL debug buildbot, EFL debug buildbot is registered > > + as trigerable bot. > > This sounds as if you're making it triggerable now. Please revise it something like "In addition, remove efl-linux-debug triggerable since nobody uses it". Thank you for your review. I fix it. Comment on attachment 143705 [details] Patch Rejecting attachment 143705 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json Hunk #1 succeeded at 294 (offset -6 lines). Hunk #2 FAILED at 319. Hunk #3 succeeded at 378 (offset -6 lines). 1 out of 3 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12797051 Created attachment 143721 [details]
Patch
Comment on attachment 143721 [details] Patch Clearing flags on attachment: 143721 Committed r118321: <http://trac.webkit.org/changeset/118321> All reviewed patches have been landed. Closing bug. |