Bug 87241

Summary: Web Inspector: eliminate getters from HeapSnapshot.js
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch yurys: review+

Description Ilya Tikhonovsky 2012-05-23 03:08:01 PDT 
getters can't be inlined by engine at the moment.
I found that convertation getters into functions gives us about 600 ms

RESULT heap-snapshot: switch-to-containment-view= 1920 ms

svs

RESULT heap-snapshot: switch-to-containment-view= 1367 ms
Comment 1 Ilya Tikhonovsky 2012-05-23 03:12:04 PDT 
Created attachment 143517 [details]
Patch
Comment 2 Yury Semikhatsky 2012-05-23 04:50:32 PDT 
Comment on attachment 143517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review

> Source/WebCore/ChangeLog:7
> +        I found that convertation getters into functions gives us about 600 ms

typo: conversion
Comment 3 Yury Semikhatsky 2012-05-23 04:56:10 PDT 
Comment on attachment 143517 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143517&action=review

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1957
> +            var valueA = typeof valueOrFunctionA !== "function" ? valueOrFunctionA : valueOrFunctionA.call(nodeA);

I guess the properties used for sorting are always functions after this change. If so please remove the typeof condition.
Comment 4 Ilya Tikhonovsky 2012-05-23 05:07:52 PDT 
Committed r118162: <http://trac.webkit.org/changeset/118162>