Bug 87202

Summary: [V8] Pass Isolate to v8::Null() in CodeGeneratorV8.pm
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-05-22 21:11:48 PDT
The objective is to pass Isolate around in V8 bindings. We pass Isolate to v8::Null() in CodeGeneratorV8.pm.
Attachments
Patch (8.30 KB, patch)
2012-05-22 21:13 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-22 21:13:14 PDT
Created attachment 143448 [details] Patch
WebKit Review Bot
Comment 2 2012-05-22 23:35:28 PDT
Comment on attachment 143448 [details] Patch Clearing flags on attachment: 143448 Committed r118129: <http://trac.webkit.org/changeset/118129>
WebKit Review Bot
Comment 3 2012-05-22 23:35:33 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 4 2012-05-23 17:11:28 PDT
Reverted r118129 for reason: some LayoutTests crash since the patch passes a NULL to Null(isolate) Committed r118274: <http://trac.webkit.org/changeset/118274>
Note You need to log in before you can comment on or make changes to this bug.