Bug 87193

Summary: [V8][Performance] Pass Isolate to v8::Null() in V8Node::toV8()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, eric.carlson, feature-media-reviews, japhet, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84074    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-05-22 18:30:58 PDT
Currently v8::Null() looks up Isolate, which is a bottleneck of V8Node::toV8() for undefined Nodes. We can remove the Isolate look-up by passing Isolate to v8::Null(), like v8::Null(isolate). This will improve the performance of Bindings/undefined-first-child.html, which tests the performance for accessing a Node object that is not yet defined.
Attachments
Patch (12.10 KB, patch)
2012-05-22 18:37 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (13.31 KB, patch)
2012-05-22 19:08 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-05-22 18:37:21 PDT
Created attachment 143430 [details] Patch
Kentaro Hara
Comment 2 2012-05-22 19:08:56 PDT
Created attachment 143435 [details] Patch
WebKit Review Bot
Comment 3 2012-05-22 21:55:45 PDT
Comment on attachment 143435 [details] Patch Clearing flags on attachment: 143435 Committed r118120: <http://trac.webkit.org/changeset/118120>
WebKit Review Bot
Comment 4 2012-05-22 21:55:51 PDT
All reviewed patches have been landed. Closing bug.
Kentaro Hara
Comment 5 2012-05-23 17:12:25 PDT
Reverted r118120 for reason: some LayoutTests crash since the patch passes a NULL to Null(isolate) Committed r118275: <http://trac.webkit.org/changeset/118275>
Note You need to log in before you can comment on or make changes to this bug.