Bug 87172

Summary: CopiedBlock and MarkedBlock should have proper value semantics (i.e., destructors)
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Geoffrey Garen
Reported 2012-05-22 14:53:32 PDT
CopiedBlock and MarkedBlock should have proper value semantics (i.e., destructors)
Attachments
Patch (19.08 KB, patch)
2012-05-22 15:07 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (19.22 KB, patch)
2012-05-22 16:37 PDT, Geoffrey Garen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2012-05-22 15:07:20 PDT
Created attachment 143373 [details] Patch
Filip Pizlo
Comment 2 2012-05-22 15:14:10 PDT
Comment on attachment 143373 [details] Patch R=me as well.
Build Bot
Comment 3 2012-05-22 15:25:29 PDT
Comment on attachment 143373 [details] Patch Attachment 143373 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12739946
Geoffrey Garen
Comment 4 2012-05-22 16:37:53 PDT
Created attachment 143397 [details] Patch
Geoffrey Garen
Comment 5 2012-05-22 16:38:18 PDT
Re-uploading to see if I can make Windows happy.
Geoffrey Garen
Comment 6 2012-05-22 16:58:55 PDT
Committed r118083: <http://trac.webkit.org/changeset/118083>
Geoffrey Garen
Comment 7 2012-05-22 16:59:27 PDT
Comment on attachment 143397 [details] Patch Oliver and Phil reviewed this.
Note You need to log in before you can comment on or make changes to this bug.