Bug 87172 - CopiedBlock and MarkedBlock should have proper value semantics (i.e., destructors)
Summary: CopiedBlock and MarkedBlock should have proper value semantics (i.e., destruc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-22 14:53 PDT by Geoffrey Garen
Modified: 2012-05-22 16:59 PDT (History)
1 user (show)

See Also:

Attachments
Patch (19.08 KB, patch)
2012-05-22 15:07 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (19.22 KB, patch)
2012-05-22 16:37 PDT, Geoffrey Garen 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-05-22 14:53:32 PDT 
CopiedBlock and MarkedBlock should have proper value semantics (i.e., destructors)
Comment 1 Geoffrey Garen 2012-05-22 15:07:20 PDT 
Created attachment 143373 [details]
Patch
Comment 2 Filip Pizlo 2012-05-22 15:14:10 PDT 
Comment on attachment 143373 [details]
Patch

R=me as well.
Comment 3 Build Bot 2012-05-22 15:25:29 PDT 
Comment on attachment 143373 [details]
Patch

Attachment 143373 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12739946
Comment 4 Geoffrey Garen 2012-05-22 16:37:53 PDT 
Created attachment 143397 [details]
Patch
Comment 5 Geoffrey Garen 2012-05-22 16:38:18 PDT 
Re-uploading to see if I can make Windows happy.
Comment 6 Geoffrey Garen 2012-05-22 16:58:55 PDT 
Committed r118083: <http://trac.webkit.org/changeset/118083>
Comment 7 Geoffrey Garen 2012-05-22 16:59:27 PDT 
Comment on attachment 143397 [details]
Patch

Oliver and Phil reviewed this.