Bug 87153

Summary:

[chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed.

Product:

WebKit

Reporter:

vollick

Component:

WebKit Misc.

Assignee:

vollick

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cc-bugs, enne, jamesr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

vollick

Reported 2012-05-22 11:40:14 PDT

Currently, when we force a sync of the animations, we blindly copy them to the impl thread. This is a problem if the main thread is waiting for a synchronized start time and the animation has already started on the main thread. In this case, we would copy the running animation over to the impl thread, where it would happily tick, but would never send an 'animation started' notification to the main thread. If the main thread animation requires this notification, we must copy the animation over in a 'waiting' state.

Attachments
Patch (4.93 KB, patch) 2012-05-22 11:42 PDT, vollick	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

vollick

Comment 1 2012-05-22 11:42:03 PDT

Created attachment 143336 [details] Patch

James Robinson

Comment 2 2012-05-23 15:27:32 PDT

Comment on attachment 143336 [details] Patch Looks good.

WebKit Review Bot

Comment 3 2012-05-24 07:13:03 PDT

Comment on attachment 143336 [details] Patch Clearing flags on attachment: 143336 Committed r118364: <http://trac.webkit.org/changeset/118364>

WebKit Review Bot

Comment 4 2012-05-24 07:13:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.