| Summary: | !HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cfleizach, eric, peter, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Barth
2012-05-22 10:05:54 PDT
Created attachment 143319 [details]
Patch
Created attachment 143320 [details]
Patch
Comment on attachment 143320 [details] Patch Attachment 143320 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12762086 Created attachment 143324 [details]
Patch
LGTM, thanks! I confirmed that this patch fixes the remaining linking error in a Chromium-Android build. Comment on attachment 143324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:1226 > +#if HAVE(ACCESSIBILITY) I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY (In reply to comment #6) > (From update of attachment 143324 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:1226 > > +#if HAVE(ACCESSIBILITY) > > I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY Me too! I tried that originally, but that didn't link on Qt. It might be worth studying why, but I don't have a Qt build to play with so I went with the path of least resistance. Comment on attachment 143324 [details] Patch Clearing flags on attachment: 143324 Committed r118012: <http://trac.webkit.org/changeset/118012> All reviewed patches have been landed. Closing bug. |