Bug 87141

Summary: !HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, eric, peter, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2012-05-22 10:05:54 PDT
!HAVE(ACCESSIBILITY) depends on AccessibilityObject::actionVerb in the Chromium Android build
Attachments
Patch (2.86 KB, patch)
2012-05-22 10:07 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2012-05-22 10:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2012-05-22 10:19 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-05-22 10:07:43 PDT
Created attachment 143319 [details] Patch
Adam Barth
Comment 2 2012-05-22 10:08:26 PDT
Created attachment 143320 [details] Patch
Early Warning System Bot
Comment 3 2012-05-22 10:15:31 PDT
Comment on attachment 143320 [details] Patch Attachment 143320 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/12762086
Adam Barth
Comment 4 2012-05-22 10:19:31 PDT
Created attachment 143324 [details] Patch
Peter Beverloo
Comment 5 2012-05-22 10:37:11 PDT
LGTM, thanks! I confirmed that this patch fixes the remaining linking error in a Chromium-Android build.
Eric Seidel (no email)
Comment 6 2012-05-22 11:28:39 PDT
Comment on attachment 143324 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:1226 > +#if HAVE(ACCESSIBILITY) I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY
Adam Barth
Comment 7 2012-05-22 11:31:22 PDT
(In reply to comment #6) > (From update of attachment 143324 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=143324&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:1226 > > +#if HAVE(ACCESSIBILITY) > > I'm surprised the rest of this file isn't wrapped in !ACCSSIBILITY Me too! I tried that originally, but that didn't link on Qt. It might be worth studying why, but I don't have a Qt build to play with so I went with the path of least resistance.
WebKit Review Bot
Comment 8 2012-05-22 11:50:01 PDT
Comment on attachment 143324 [details] Patch Clearing flags on attachment: 143324 Committed r118012: <http://trac.webkit.org/changeset/118012>
WebKit Review Bot
Comment 9 2012-05-22 11:50:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.